fix(cable): return ConnectionFailed for both Terminated paths#222
Merged
Merged
Conversation
wait_for_connection returned ConnectionLost when the channel was already Terminated on entry, but ConnectionFailed when it became Terminated during the changed() await. The caller can't observe which path it took, so the two variants are an accidental asymmetry that makes downstream matches fragile. Both paths now return ConnectionFailed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_connectionreturnedConnectionLoston an entry-timeTerminatedbutConnectionFailedon a transition-timeTerminated. The caller can't observe which path it took, so the two variants are an accidental asymmetry that makes downstreammatches fragile. Both paths now returnConnectionFailed.Test plan
cargo build -p libwebauthncargo test -p libwebauthn